fix(framework:skip) Remove setting init_args for Backend in run_simulation entry point
#3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafermarq
changed the title
run_simulation entry point.run_simulation entry point.
jafermarq
changed the title
run_simulation entry point.init_args for Backend in run_simulation entry point.
jafermarq
changed the title
init_args for Backend in run_simulation entry point.init_args for Backend in run_simulation entry point
|
Made redundant by #3963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3543 , we made it possible to easily pass
init_argsto the Backend. These are designed to be backend-agnostic. In the case of theRayBackendthelog_to_driversetting can be use to "silence" all logs coming from ray actors (e.g. theClientAppobjs. This is useful in some settings.The change in the PR removes setting this to True (it's True by default anyway in Ray), allowing users to changing it to false via the
backend_configargument if desired.