Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(*:skip) Align Ubuntu image with Alpine image #3713

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

Robert-Steiner
Copy link
Member

@Robert-Steiner Robert-Steiner commented Jul 4, 2024

Issue

Description

  • Align the order of the instructions to match the order of the Alpine Docker image.
  • Fix the false positive CVE-2022-40897⁠. To add some context: Docker scout complains about setuptools 65.5.0 in layer 8 but we upgrade the version to 69.5.1 in layer 16 so the vulnerability is not in the final image. The issue is fixed by installing/upgrading setuptools in the first stage of the multi-stage build and then only copy the virtual env to the final stage.
  • Reduce one layer in the final image.

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@Robert-Steiner Robert-Steiner changed the title refactor(*:skip) align ubuntu image with apline image refactor(*:skip) Align ubuntu image with apline image Jul 4, 2024
@Robert-Steiner Robert-Steiner self-assigned this Jul 8, 2024
@Robert-Steiner Robert-Steiner marked this pull request as ready for review July 9, 2024 07:25
@Robert-Steiner Robert-Steiner changed the title refactor(*:skip) Align ubuntu image with apline image refactor(*:skip) Align Ubuntu image with Alpine image Jul 9, 2024
@tanertopal tanertopal enabled auto-merge (squash) July 10, 2024 08:24
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tanertopal tanertopal merged commit 8e8fb22 into main Jul 10, 2024
28 checks passed
@tanertopal tanertopal deleted the refactor/base-docker-ubuntu branch July 10, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants