refactor(examples) Update quickstart-mlx example
#3701
+302
−536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel J. Beutel <[email protected]>
charlesbvll
reviewed
Jul 24, 2024
charlesbvll
reviewed
Jul 24, 2024
ok! What would you propose? something minimal as what's generated by the templates? |
jafermarq
commented
Jul 24, 2024
examples/quickstart-mlx/README.md
Outdated
| @@ -129,30 +107,30 @@ data = ( | |||
| test_partition["label"].astype(np.uint32), | |||
| ) | |||
|
|
|||
| train_images, train_labels, test_images, test_labels = map(mlx.core.array, data) | |||
| train_images, train_labels, test_images, test_labels = map(mx.array, data) | |||
| ``` | |||
|
|
|||
| ### The model | |||
There was a problem hiding this comment.
@charlesbvll how about if we remove the model block. in the end this is not so Flower-specific...
There was a problem hiding this comment.
I think we could remove the code (so we don't have to maintain the same code in 2 different places), but it might be good to keep some explanation of what the model is and what it is doing to give some context
jafermarq
commented
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
examples/quickstart-mlxto make itflwr run-compatible. Code generated viaflwr new, then adapted to the newclient_fnlogic.