Add upd support #50
Open
Add upd support #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… they can be modified easily at runtime. Added some commands that are needed to open the TCPIP connection, like CSTT, CIICR and CIFSR, according to the Application Note. All this changes were tested with a UDP connection.
Converted some strings in code to be on flash memory address space instead. Added a time delay to test for the CSTT answer. Added methods to fix the TCPIP client port number, or to make it dinamyc allocated. Changed to tests for UDP first, since UDP is used in performance based aplications, this will be preferred (little impact, but, why not?).
conditional compile for Adafruit Feather M0 and other SAMD boards: removes SoftwareSerial
v 1.3.1, reflects update to FONA_SMS_Response example
- Ensure the command is sent on one line by replacing some println() by print() - Remove duplicated send to AT+CSTT - Use expectReply() for AT+CSTT answer check and only return on failure
…king the Max Response Time from the AT Command Manual, but leaving a little bit of safe margin too.
Changed some F("OK") left to ok_reply.
Fixed the begin method to have the right parameter type.
Removed some PSTR left in code since the major re-organization, so there could be better portability.
Removed the ADAFRUIT_FONA_DEBUG as "on" as default. I guess most users won't wan't this on at firts, since this only helps coders of the library.
Changed all the TCPIP methods. The old ones were left for backward compatibility.
Added the hability to have a TCP or a UDP connection. Code is all commented.
Added the enableGPRS() and disableGPRS(). The old enableGPRS(onoff) was left for backward compatibility.
Changed the way the APN is stored, now all strings are stored in RAM memory so the user can change APN propetries on the fly if needed, without the need to recompile the code (but still can be passed as flash memory strings).
Added new string manipulation functions Macros for progmem strings compatibility.
|
it will be a while till i do another run at FONA updates - have a large number of other libraries needing updates. but note that i really dont want to merge any code with malloc/free, its just too risky on a 2KB uno. better to have a fixed buffer size for APN details, then strcpy them around? |
|
Agreed, I don't think also anyone will need more than 100 characters for I will fix this and push it soon. |
Added a string validation method.
|
@ladyada fixed. |
…ods. The Bearer Profile has to be configured to have HTTP, GSM Location and other functionalities from the modem.
… the constructor, giving him more flexibility on his memory management. Updated the examples to reflect all the modifications done so far in the library.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected several things from master (as explained in the 9734329 commit, copied below), but specially made new TCPIP methods so now it's possible to send data over a UDP or TCP connection. Also I made methods for
enablinganddisablingthe GPRS connection. I don't understand why there is theAT+SAPBRcommand in the originalenable(onoff)method, since the TCPIP manual don't even mentions it. I think these names (enable and disable) make more sense and the code is easier to read, also it's full compliant with the TCPIP Manual. could someone please tell me why there is theAT+SAPBRcommand in the original method? I never could make it work, and also I can't see the need for it.My code is tested on UDP connetions (I don't have a TCP socket to test, but I can't see why it should't work too).
All this changes I already had for a couple months, I was just testing them in my project before sending. Some of my modifications were already applied in the library in the past commits, as the lack of
AT+CIICR.... but still you needAT+CIFSR.Feel free to discuss my modifications, I understand merge won't be automatic, since I am in a pretty old common base commit, but I tried to make things easier by applying all your recent commits to my branch.
Commit 9734329 message:
Corrected the timeout of some AT commands (CIPSHUT, SAPBR, CIICR), taking the Max Response Time from the AT Command Manual, but leaving a little bit of safe margin too.
Changed some F("OK") left to ok_reply.
Fixed the begin method to have the right parameter type.
Removed some PSTR left in code since the major re-organization, so there could be better portability.
Removed the ADAFRUIT_FONA_DEBUG as "on" as default. I guess most users won't wan't this on at firts, since this only helps coders of the library.
Changed all the TCPIP methods. The old ones were left for backward compatibility.
Added the hability to have a TCP or a UDP connection. Code is all commented.
Added the enableGPRS() and disableGPRS(). The old enableGPRS(onoff) was left for backward compatibility.
Changed the way the APN is stored, now all strings are stored in RAM memory so the user can change APN propetries on the fly if needed, without the need to recompile the code (but still can be passed as flash memory strings).
Added new string manipulation functions Macros for progmem strings compatibility.
EDIT:
I found out that although the SAPBR commands aren't needed for TCPIP commands, they are needed for the HTTP, FTP, GSM location and maybe other functionalities to work. Added it on the e135e3f commit.