Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wake Future when EOF is received #3492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Wake Future when EOF is received #3492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions actix-http/CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Added

- Add `header::CLEAR_SITE_DATA` constant.
- Fix bug which prevents end-users from discovering when the remote peer has closed its side of the TCP connection.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be in a new ### Fixed section rather than in "Added"


### Changed

Expand Down
1 change: 1 addition & 0 deletions actix-http/src/h1/payload.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ impl Inner {
#[inline]
fn feed_eof(&mut self) {
self.eof = true;
self.wake();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. I can imagine a scenario where Payload is polled before EOF comes in, and then EOF comes in and Payload is not woken.

}

#[inline]
Expand Down
Loading