New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure TCP connection is properly shut down when Session is dropped #476

Open

centromere wants to merge 1 commit into actix:master from centromere:close-connection-when-session-is-dropped

centromere commented Nov 1, 2024

PR Type

Bug fix

PR Checklist

Tests for the changes have been added / updated.
Documentation comments have been added / updated.
A changelog entry has been made for the appropriate packages.
Format code with the nightly rustfmt (cargo +nightly fmt).

Overview

When a Session falls out of scope, StreamingBody's poll_next ought to return Poll::Ready(None), not Poll::Pending.

Relates to: actix/actix-web#3093


          Ensure TCP connection is properly shut down when session is dropped

c8d9d06

asonix approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet