fix(session): fix double serialisation of values when inserting data into session state #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey 👋. I'm experiencing this issue, can I participate on this PR to be merged asap? At this moment I have a messy workaround and this would simplify the logic and clear my messy code just for this. |
robjtede
added
A-session
willothy
added a commit
to fortress-build/actix-extras
that referenced
this pull request
Nov 19, 2024
Use `serde_json::Map<String, serde_json::Value>` instead of `HashMap<String, String>`. Has the added benefit of fully type-safe json storage in sessions. see actix#366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Bug Fix
PR Checklist
cargo +nightly fmt).Overview
Replaces the usage of HashMap in session with serde Map, which solves the issue of double-serialization of values when inserting data into the session state.
Closes #308