Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix netprotections logos. #921

Merged
merged 8 commits into from
Sep 6, 2023
Merged

Conversation

kkasamoto
Copy link
Contributor

@kkasamoto kkasamoto commented Sep 3, 2023

Why are you adding this icons?

There was a mistake in the logo added through a pull request, #865 , so I want to fix it.

Help us identify yourself

  • I'm working/collaborating with the brand directly and they have provided the icons.
  • I'm associated with the brand and I've read all the brand icon’s guidelines.
  • I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines:

Checklist to add new icons

  • All icons have a corresponding entry in db/payment_icons.yml
  • I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • I have optimized the icon with SVGO
  • I am confident that all icons are clear and easy to read/understand
  • I have provided a link to the brand icon’s brand guidelines whenever possible.
  • I have attached a screenshot comparison with the example icon provided in guidelines
  • I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

image

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)

What's the expected date of this change to deploy on Shopify?

@kkasamoto kkasamoto changed the title fix npatobari.svg and npkakebarai.svg fix netprotections logos. Sep 3, 2023
@adeniyiao adeniyiao merged commit 8adc9ea into activemerchant:master Sep 6, 2023
11 checks passed
@shopify-shipit-activemerchant shopify-shipit-activemerchant bot temporarily deployed to rubygems September 6, 2023 15:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants