-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new icons for efecty, nequi and yape, also fix Visa icon th… #1221
Open
Candres1019
wants to merge
18
commits into
activemerchant:master
Choose a base branch
from
Candres1019:add_icons_yape_nequi_efecty_and_fix_visa
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
691f754
feat: Add new icons for efecty, nequi and yape, also fix Visa icon th…
Candres1019 ef12580
feat: Fix id in some parts of the svg
Candres1019 0bfb8d1
feat: Fix id in some parts of the svg
Candres1019 2c70bca
feat: Add title tag to nequi svg
Candres1019 6c128b0
feat: Add role tag to nequi svg
Candres1019 44fad47
Merge branch 'master' into add_icons_yape_nequi_efecty_and_fix_visa
Candres1019 7e80f4f
Update payment_icons.yml
dannye0231 a0d0c61
Removed extra white space after dash
dannye0231 c6a5b8c
Removed carriage return at the end of the file
dannye0231 ec87f75
changed id from visa to pi-visa
dannye0231 dee373a
feat: add pi-yape-clippath to svg config
Candres1019 412b7ff
feat: fix capa id for yape
Candres1019 c3e951f
Update yape.svg to include pi- prefix in id field
dannye0231 c40ffa1
Merge branch 'master' into add_icons_yape_nequi_efecty_and_fix_visa
dannye0231 3fcb77d
feat: svgo to yape icon
Candres1019 cdb993e
feat: svgo to yape icon
Candres1019 51d7bba
feat: svg yape fix
Candres1019 65f4801
feat: svg yape fix
Candres1019 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dannye0231 We're not changing major card icons right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lydia-shan-git you are correct, these PRs would only apply to the individual payment integration icons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Candres1019 , are you able to omit the Visa icon change from this PR and only keep your payment integration icon in scope?