Skip to content

Commit

Permalink
Merge pull request #387 from k3rni/update-shopify-money
Browse files Browse the repository at this point in the history
Change shopify-money version to >= 2.0 in gemspec.
  • Loading branch information
AnotherJoSmith authored Oct 7, 2024
2 parents 621f988 + 09db35f commit 4a3926e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 17 deletions.
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ PATH
builder (>= 2.1.2, < 4.0.0)
i18n (>= 0.6.6)
nokogiri (>= 1.8.5)
shopify-money (~> 2.0)
shopify-money (>= 2.0)

GEM
remote: https://rubygems.org/
Expand Down Expand Up @@ -221,7 +221,7 @@ GEM
rubyntlm (0.6.5)
base64
securerandom (0.3.1)
shopify-money (2.2.2)
shopify-money (3.0.0)
stringio (3.1.1)
test-unit (3.6.2)
power_assert
Expand Down
15 changes: 1 addition & 14 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
> [!CAUTION]
> [!CAUTION]
> This gem is not actively maintained, and many of the integrations have not been updated in years. It is deprecated at Shopify, and should not be used.
# Offsite Payments
Expand Down Expand Up @@ -40,19 +40,6 @@ Or, if you're using Bundler, just add the following to your Gemfile:

gem 'offsite_payments'

### Money gem dependency

At the moment, `offsite_payments` gem depends on `Money` object, which was previously included by default. Since Shopify
released their own `shopify-money` gem. Because `offsite_payments` does not impose which one of those gems should be
included into your gem file, as long as one of them is included.


- For [ruby money gem](https://github.com/RubyMoney/money) add `gem 'money'` to your `Gemfile`;
- For [Shopify money gem](https://github.com/Shopify/money) add `gem 'shopify-money', require: 'money'` in your `Gemfile`.

It's important to note that either of those Money gems would need to be added to your `Gemfile` before the `offsite_payments`
one.

[API documentation](http://www.rubydoc.info/github/activemerchant/offsite_payments/master).

## Supported Integrations
Expand Down
2 changes: 1 addition & 1 deletion offsite_payments.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Gem::Specification.new do |s|

s.metadata['allowed_push_host'] = "https://rubygems.org"

s.add_dependency('shopify-money', '~> 2.0')
s.add_dependency('shopify-money', '>= 2.0')
s.add_dependency('activesupport', '>= 7.2.0')
s.add_dependency('i18n', '>= 0.6.6')
s.add_dependency('builder', '>= 2.1.2', '< 4.0.0')
Expand Down

0 comments on commit 4a3926e

Please sign in to comment.