Skip to content

Commit

Permalink
Lock Gemfile-shopify to money 0.14.x
Browse files Browse the repository at this point in the history
The `Gemfile.shopify` file doesn't specify a version of money to use.
I'm not entirely sure _why_ that's the case, but it seems like an
unnecessary risk to me that can just lead to headaches.

A particular headache I'm currently experiencing (and that's
prompting me to lock this) is that Money 0.15 was just released
and several tests began to fail because of that.

Let's keep the minor version locked for now to prevent breakages
introduced by functionality changes.
  • Loading branch information
zbriscoe committed Jan 20, 2021
1 parent 6681e0d commit 3aedf7c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gemfiles/Gemfile.shopify
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ group :remote_test do
end

gem 'actionpack', '~> 6.0.0'
gem 'shopify-money', require: 'money'
gem 'shopify-money', '~> 0.14.0', require: 'money'

0 comments on commit 3aedf7c

Please sign in to comment.