Worldpay: Update where to pass shopperIPAddress #5348
Merged
+43
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, two questions
|
cvc was not the issues only shopperIPAddress. I can add that but only email one since the other ones are normal used for 3DS |
almalee24
force-pushed
the
update_worldpay_fast_access_request
branch
from
e8b09be
to
b78d52f
Compare
almalee24
force-pushed
the
update_worldpay_fast_access_request
branch
3 times, most recently
from
925404b
to
af2d1af
Compare
For NetworkTokens shopperIPAddress should be passed after the stored credentials fields. And for Fast Access transactions shopperIPAddress should be passed within paymentDetails Remote 117 tests, 498 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 98.2906% passed Unit 134 tests, 743 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For NetworkTokens shopperIPAddress should be passed after the stored credentials fields. And for Fast Access transactions shopperIPAddress should be passed within paymentDetails
Remote
117 tests, 498 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 98.2906% passed
Unit
134 tests, 743 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed