Credorax: Add support for gateway card validation #5332
+61
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreiff
reviewed
Nov 12, 2024
| @@ -164,6 +164,7 @@ def authorize(amount, payment_method, options = {}) | |||
| add_3ds_2_optional_fields(post, options) | |||
| add_echo(post, options) | |||
| add_submerchant_id(post, options) | |||
| add_cardholder_name_inquiry(post, options) | |||
There was a problem hiding this comment.
I wonder if this should come after add_stored_credential in the order of sub-methods?
The reason being that a9 is also set in that submethod, either by applying the transaction_type that is passed in, or defaulting to 9 if it's a CIT.
In this current order, I think there's a risk that the a9 value we're setting would get overwritten 😬
rachelkirk
force-pushed
the
CER-1810_credorax_zfields
branch
from
15d05f1
to
9198751
Compare
This change allows the `cardholder_name_inquiry` flag to be sent. If set to true, it will trigger first and last name data to be sent for c22, and c23. $0 auth transactions to validate cards also require the value for a9 to be set to 5. Remote Tests: 54 tests, 176 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 88.4615% passed Unit Tests 83 tests, 399 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
rachelkirk
force-pushed
the
CER-1810_credorax_zfields
branch
from
9198751
to
3420a55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the
cardholder_name_inquiryflag to be sent. If set to true, it will trigger first and last name data to be sent for c22, and c23. $0 auth transactions to validate cards also require the value for a9 to be set to 5.Remote Tests:
52 tests, 176 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 88.4615% passed
*6 failing tests also failing on master
Unit Tests
83 tests, 399 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed