Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worldpay: Update Stored Credentials #5330

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

almalee24
Copy link
Contributor

Update add_stored_credential_using_normalized_fields to
only send usage: 'USED' with merchantInitiatedReason and
only send reason if it's recurring or installment.

Unit:
133 tests, 741 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
114 tests, 489 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
97.3684% passed

@almalee24 almalee24 requested a review from a team November 11, 2024 17:52
Copy link
Contributor

@sinourain sinourain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

    Update add_stored_credential_using_normalized_fields to
    only send usage: 'USED' with merchantInitiatedReason and
    only send reason if it's recurring or installment.

    Unit:
    133 tests, 741 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
    100% passed

    Remote:
    114 tests, 489 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
    97.3684% passed
@almalee24 almalee24 merged commit 88bdf59 into master Nov 20, 2024
0 of 5 checks passed
@almalee24 almalee24 deleted the update_worldpay_stored_creds branch November 20, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants