Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to Billing::Integrations #3692

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Remove reference to Billing::Integrations #3692

merged 1 commit into from
Jun 29, 2020

Conversation

pi3r
Copy link
Contributor

@pi3r pi3r commented Jun 29, 2020

This is a remnant of when all offsites gateway were extracted to
OffsitPayments. The namespace Billing::Integrations doesn't
exist anymore.

References #3503 (comment)

irb(main):001:0> require 'activemerchant'
=> true
irb(main):002:0> ActiveMerchant
=> ActiveMerchant
irb(main):003:0> ActiveMerchant::Billing
=> ActiveMerchant::Billing
irb(main):004:0> ActiveMerchant::Billing::Integrations
Traceback (most recent call last):
        4: from /opt/rubies/2.6.5/bin/irb:23:in `<main>'
        3: from /opt/rubies/2.6.5/bin/irb:23:in `load'
        2: from /opt/rubies/2.6.5/lib/ruby/gems/2.6.0/gems/irb-1.0.0/exe/irb:11:in `<top (required)>'
        1: from (irb):4
NameError (uninitialized constant ActiveMerchant::Billing::Integrations)

This is a remnant of when all offsites gateway were extracted to
`OffsitPayments`. The namespace `Billing::Integrations` doesn't
exist anymore.
@pi3r pi3r force-pushed the remove-dead-code branch from 3744baf to d2867b6 Compare June 29, 2020 17:50
Copy link

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pi3r pi3r merged commit be9fb7c into master Jun 29, 2020
@pi3r pi3r deleted the remove-dead-code branch June 29, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants