Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add dynamically loaded cache-dependencies module #728

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aminya
Copy link

@aminya aminya commented Sep 8, 2023

Description:
This reduces the main bundle size by ⚠️ 1.28 MB minified! This bundle is loaded only when caching is enabled.

setup-python is used in setup-cpp as a library. This optimization reduces the bundle size for that package as well. The build system of setup-python uses ncc, which doesn't immediately benefit from this change, but setup-cpp uses Parcel, which shows this huge improvement.

The reason for this huge reduction is that caching the dependencies uses the @actions/cache package, which is an extremely large package with big dependencies. The bundle size before this separation shows this:
Screenshot_20230907_230625

Related issue:

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

This reduces the main bundle size by ⚠️  1.1 MB minified! This bundle is loaded only when caching is enabled.

The reason for this huge reduction is that caching dependencies uses the `@actions/cache` package, which is an extremely large package with big dependencies.

`setup-python` is used in `setup-cpp` as a library. This optimization reduces the bundle size for that package as well.
@aminya
Copy link
Author

aminya commented Sep 20, 2024

@konradpabjan could you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant