Skip to content

Commit

Permalink
fix review issues
Browse files Browse the repository at this point in the history
  • Loading branch information
beeequeue committed Aug 28, 2022
1 parent f4604a7 commit 3e2f891
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions __tests__/installer.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -385,10 +385,10 @@ describe('setup-node', () => {
os.platform = 'linux';
os.arch = 'x64';

inputs['node-version'] = '12';
inputs['node-version'] = '16';
inputs['corepack'] = 'true';

const toolPath = path.normalize('/cache/node/12.16.1/x64');
const toolPath = path.normalize('/cache/node/16.17.0/x64');
findSpy.mockReturnValue(toolPath);
await main.run();

Expand Down
4 changes: 2 additions & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ inputs:
description: 'Set this option if you want the action to check for the latest available version that satisfies the version spec.'
default: 'false'
corepack:
description: 'Set this option if you want to install the core-pack.'
description: 'Automatically enables corepack'
default: 'false'
registry-url:
description: 'Optional registry to set up for auth. Will set the registry in a project level .npmrc and .yarnrc file, and set up auth to read in from env.NODE_AUTH_TOKEN.'
Expand All @@ -28,7 +28,7 @@ inputs:
description: 'Used to specify a package manager for caching in the default directory. Supported values: npm, yarn, pnpm.'
cache-dependency-path:
description: 'Used to specify the path to a dependency file: package-lock.json, yarn.lock, etc. Supports wildcards or a list of file names for caching multiple dependencies.'
# TODO: add input to control forcing to pull from cloud or dist.
# TODO: add input to control forcing to pull from cloud or dist.
# escape valve for someone having issues or needing the absolute latest which isn't cached yet
outputs:
cache-hit:
Expand Down
4 changes: 2 additions & 2 deletions docs/advanced-usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ steps:
- uses: actions/setup-node@v3
with:
node-version: '14.x'
corepack: enable
corepack: true
```

It is recommended to configure `package.json#packageManager` if you want to use it.
Expand All @@ -310,7 +310,7 @@ e.g.
```json
{
"name": "example",
"packageManager": "pnpm@7.5.2",
"packageManager": "pnpm@7.9.5",
// ...
}
```
Expand Down

0 comments on commit 3e2f891

Please sign in to comment.