fix: add arch to cache key #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kolyshkin This mainly happens on macOS amd64/arm64, and the previous patch didn't resolve it. |
aparnajyothi-y
approved these changes
Aug 14, 2024
aparnajyothi-y
approved these changes
Aug 14, 2024
I agree. Yet one day we'll have Windows and Linux on ARM and this will be needed there as well. Thanks for adding, LGTM(NB). |
|
For GitHub Enterprise we already have Linux arm64 provided by ARM. |
priyagupta108
approved these changes
Aug 16, 2024
HarithaVattikuti
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
GitHub has added the arm64 runner, so arch should be used as part of the cache key. Otherwise, if there are
macos-13macos-14running at the same time, the late executor will get the wrong cache.Related issue:
actions/setup-python#896
Check list: