This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 91
Properly remove all deprecations #224
Open
ThexXTURBOXx
wants to merge
6
commits into
actions-rs:master
Choose a base branch
from
ThexXTURBOXx:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@actions/core: ^1.10.0 @actions/exec: ^1.1.1 @actions/io: ^1.1.2 close actions-rs#221
any ETA on this ? |
@Roms1383 I am pretty sure this will not get merged any time soon. on: [push]
name: build
jobs:
check:
name: Rust project
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Install latest nightly
uses: ThexXTURBOXx/toolchain@master
with:
toolchain: nightly
override: true
components: rustfmt, clippy
# `cargo check` command here will use installed `nightly`
# as it is set as an "override" for current directory
- name: Run cargo check
uses: richb-hanover/cargo@master
with:
command: check |
I do not believe this will get merge anytime soon - maybe not at all. :( In the meantime, users of this action may consider using
|
deep-soft
added a commit
to deep-soft/rust-toolchain-actions-rs
that referenced
this pull request
Oct 6, 2023
This PR supersedes actions-rs#220 and actions-rs#222 by applying both fixes at once Fixes actions-rs#219 Fixes actions-rs#221 You can now use this action (and cargo) without deprecations by using a workflow similar to this: on: [push] name: build jobs: check: name: Rust project runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - name: Install latest nightly uses: ThexXTURBOXx/toolchain@master with: toolchain: nightly override: true components: rustfmt, clippy # `cargo check` command here will use installed `nightly` # as it is set as an "override" for current directory - name: Run cargo check uses: richb-hanover/cargo@master with: command: check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #220 and #222 by applying both fixes at once
Fixes #219
Fixes #221
You can now use this action (and cargo) without deprecations by using a workflow similar to this: