Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Properly remove all deprecations #224

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ThexXTURBOXx
Copy link

@ThexXTURBOXx ThexXTURBOXx commented Nov 5, 2022

This PR supersedes #220 and #222 by applying both fixes at once

Fixes #219
Fixes #221

You can now use this action (and cargo) without deprecations by using a workflow similar to this:

on: [push]

name: build

jobs:
  check:
    name: Rust project
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - name: Install latest nightly
        uses: ThexXTURBOXx/toolchain@master
        with:
            toolchain: nightly
            override: true
            components: rustfmt, clippy

      # `cargo check` command here will use installed `nightly`
      # as it is set as an "override" for current directory

      - name: Run cargo check
        uses: richb-hanover/cargo@master
        with:
          command: check

@Roms1383
Copy link

any ETA on this ?

@ThexXTURBOXx
Copy link
Author

ThexXTURBOXx commented Mar 29, 2023

@Roms1383 I am pretty sure this will not get merged any time soon.
I also did not just want to steal the work from the other two PRs.
The reason for this PR is the following:
You can now use this action (and cargo) without deprecations by using a workflow similar to this:

on: [push]

name: build

jobs:
  check:
    name: Rust project
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - name: Install latest nightly
        uses: ThexXTURBOXx/toolchain@master
        with:
            toolchain: nightly
            override: true
            components: rustfmt, clippy

      # `cargo check` command here will use installed `nightly`
      # as it is set as an "override" for current directory

      - name: Run cargo check
        uses: richb-hanover/cargo@master
        with:
          command: check

@striezel
Copy link

striezel commented May 7, 2023

any ETA on this ?

I do not believe this will get merge anytime soon - maybe not at all. :(

In the meantime, users of this action may consider using dtolnay/rust-toolchain instead. It is maintained and does not cause any deprecation warnings. Usage is similar to actions-rs/toolchain, so it can be used as a replacement:

name: test suite
on: [push, pull_request]

jobs:
  test:
    name: cargo test
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: dtolnay/rust-toolchain@master
        with:
          toolchain: stable
          components: clippy, rustfmt
      - run: cargo clippy
      - run: cargo fmt
      - run: cargo test --all-features

deep-soft added a commit to deep-soft/rust-toolchain-actions-rs that referenced this pull request Oct 6, 2023
This PR supersedes actions-rs#220 and actions-rs#222 by applying both fixes at once
Fixes actions-rs#219
Fixes actions-rs#221

You can now use this action (and cargo) without deprecations by using a workflow similar to this:

on: [push]

name: build

jobs:
  check:
    name: Rust project
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - name: Install latest nightly
        uses: ThexXTURBOXx/toolchain@master
        with:
            toolchain: nightly
            override: true
            components: rustfmt, clippy

      # `cargo check` command here will use installed `nightly`
      # as it is set as an "override" for current directory

      - name: Run cargo check
        uses: richb-hanover/cargo@master
        with:
          command: check
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

set-output command is deprecated Node.JS 12 deprecation on GitHub Actions
5 participants