Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial tweaks to object name rule #2218

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

WilcoFiers
Copy link
Member

There is an inconsistency between the background which says that screen readers ignore object without an empty name, and the accessibility support section which says that some don't.

Need for Call for Review: none, editorial upcate


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Copy link
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an "if present" to clarify the usage of fallback content

_rules/object-has-accessible-name-8fc3b6.md Outdated Show resolved Hide resolved
carlosapaduarte

This comment was marked as duplicate.

carlosapaduarte

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants