improve(unwrapWeth): load WETH addresses from constants #1840
+11
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaspai
requested review from
mrice32,
pxrl and
james-a-morris
as code owners
nicholaspai
changed the title
pxrl
reviewed
Sep 26, 2024
scripts/unwrapWeth.ts
Outdated
| @@ -23,6 +23,7 @@ const WETH_ADDRESSES = { | |||
| 288: "0xDeadDeAddeAddEAddeadDEaDDEAdDeaDDeAD0000", | |||
| 324: "0x5AEa5775959fBC2557Cc8789bC1bf90A239D9a91", | |||
| 8453: "0x4200000000000000000000000000000000000006", | |||
| 7777777: "0x4200000000000000000000000000000000000006", | |||
There was a problem hiding this comment.
Should we just import { TOKEN_SYMBOLS_MAP } from ../src/utils and dereference TOKEN_SYMBOLS_MAP.WETH.addresses[chainId]? Then we get these addresses for free.
nicholaspai
changed the title
pxrl
approved these changes
Sep 29, 2024
james-a-morris
approved these changes
Sep 30, 2024
| @@ -36,10 +34,10 @@ export async function run(): Promise<void> { | |||
| const signerAddr = await baseSigner.getAddress(); | |||
| const chainId = Number(args.chainId); | |||
| const connectedSigner = baseSigner.connect(await getProvider(chainId)); | |||
| if (!isKeyOf(chainId, WETH_ADDRESSES)) { | |||
| if (!TOKEN_SYMBOLS_MAP.WETH.addresses[chainId]) { | |||
There was a problem hiding this comment.
Could we convert this to an assert( )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple refactor to re-use constants