Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Dynamically adjust proposal block ranges #1139

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

feat: Dynamically adjust proposal block ranges #1139

wants to merge 23 commits into from
+356 −12

Commits on Jan 5, 2024

  1. feat: Dynamically adjust proposal block ranges 

    This commit introduces dynamic adjustment of the block ranges that the
proposer will propose. The intention of this change is to make the
proposer more robust to incomplete or inconsistent data being supplied
by one or more RPC providers.

Dynamic adjustment is enacted in the event that any of the following
conditions are detected:
 - An invalid fill traces to a missing deposit (no deposit found for
   the specified depositId).
 - A deposit is known to be filled, without any associated FilledRelay
   event.

In the first case, this results in narrowing of the block range on both
the origin and destination chains. For the latter, only the destination
chain is narrowed.
    @pxrl
    pxrl committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    02e2363 View commit details
    Browse the repository at this point in the history

  2. Re-enable disabled tests

    @pxrl
    pxrl committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    cb9186a View commit details
    Browse the repository at this point in the history

  3. Return finalBlockRanges

    @pxrl
    pxrl committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    b3d31e9 View commit details
    Browse the repository at this point in the history

  4. Undo unnecessary change

    @pxrl
    pxrl committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    d029d53 View commit details
    Browse the repository at this point in the history

  5. Additional cleanup

    @pxrl
    pxrl committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    ee01c7e View commit details
    Browse the repository at this point in the history

  6. Relocate block range shuffling to proposer-only workflow

    @pxrl
    pxrl committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    314073f View commit details
    Browse the repository at this point in the history

  7. Relocate block range narrowing further upstream in proposer workflow

    @pxrl
    pxrl committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    fb12aa0 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Merge branch 'master' into pxrl/dynamicProposalRange

    @pxrl
    pxrl authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    f0cb419 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Fix tests

    @pxrl
    pxrl committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    ccb5df0 View commit details
    Browse the repository at this point in the history

  2. Simplify end block updating

    @pxrl
    pxrl committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    c716ee8 View commit details
    Browse the repository at this point in the history

  3. lint

    @pxrl
    pxrl committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    a990ee7 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Fix comment 

    Suggested by Matt.

Co-authored-by: Matt Rice <[email protected]>
    @pxrl @mrice32
    pxrl and mrice32 authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    51df1ca View commit details
    Browse the repository at this point in the history

  2. Nuke stray newline

    @pxrl
    pxrl authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    70f65e9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into pxrl/dynamicProposalRange

    @nicholaspai
    nicholaspai authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    4697b59 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Back out "missing fills" change 

    Proceeding with the initial "invalid fills" change alone. The subsequent
change can be re-introduced later.
    @pxrl
    pxrl committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    093d80b View commit details
    Browse the repository at this point in the history

  2. lint

    @pxrl
    pxrl committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7a17005 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into pxrl/dynamicProposalRange

    @pxrl
    pxrl authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3a5b2c1 View commit details
    Browse the repository at this point in the history

  4. Add comment 

    Proposed by Nick.

Co-authored-by: nicholaspai <[email protected]>
    @pxrl @nicholaspai
    pxrl and nicholaspai authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    677c8b9 View commit details
    Browse the repository at this point in the history

  5. reflow comment

    @pxrl
    pxrl committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c8673dc View commit details
    Browse the repository at this point in the history

  6. Clarify iterative updates

    @pxrl
    pxrl committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7559948 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Merge branch 'master' into pxrl/dynamicProposalRange

    @pxrl
    pxrl authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    6c19e4b View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Merge remote-tracking branch 'origin/master' into pxrl/dynamicProposa… 

    …lRange
    @pxrl
    pxrl committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    5c88581 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. lint

    @pxrl
    pxrl committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    56bef8c View commit details
    Browse the repository at this point in the history