Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPD-7592 keep standard tags when updating #290

Open
wants to merge 1 commit into
base: proxy-cli-hook-aws-v2
Choose a base branch
from
Open

CPD-7592 keep standard tags when updating #290

wants to merge 1 commit into from
+9 −1

Conversation

lethanh273
Copy link

@lethanh273 lethanh273 commented Nov 30, 2022 •
edited
Loading

Change: patch
Purpose: maintenance

Manual testing:
in cloud-database-api folder, replace moonshot with 

  gem 'moonshot',      git: '[email protected]:lethanh273/moonshot.git',      ref: 'master'

bundle update moonshot 
cd network 
bundle exec moonshot update -n dev-ltt
rm cloud_formation/cdb-network.json if need to
The stack tags will be kept as they are.

kaushik
kaushik requested changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@kaushik kaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of cloud data specific information should be in moonshot. This is an independent gem used to manage cloud formation deployments.

@lethanh273
CPD-7592 keep standard tags when updating
11180be 
Change: patch
Purpose: maintenance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushik kaushik kaushik requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lethanh273 @kaushik