Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sample to use current moonshot version. #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomelliot16
Copy link
Contributor

Seems the version should be bumped

@tomelliot16 tomelliot16 changed the title Why not use current versions? Set sample to use current moonshot version. Dec 31, 2016
Copy link
Contributor

@askreet askreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt the sample app has been updated to be 1.x compatible. Does it have a Moonfile.rb?

@tomelliot16
Copy link
Contributor Author

@askreet Has a Moonfile but no Moonfile.rb. It should probably be added with this patch. It's in the same format right or did it change?

Seems the version should be bumped
@tomelliot16
Copy link
Contributor Author

tomelliot16 commented Jan 1, 2017

@askreet lol travis is mad at your naming convention 😝 Makefile.rb is not in snake case. Should we add it to the ignore list?

@askreet
Copy link
Contributor

askreet commented Jan 27, 2017

@tomelliot16 Yeah, I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants