LCH-5237: Outputting information about exception. #12
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,14 +47,16 @@ protected function execute(InputInterface $input, OutputInterface $output) { | |||
| } | |||
| // @TODO: This needs to be fixed. The 'https' is not present in the URL. | |||
| if (strpos($url, 'https') !== 0) { | |||
| $output->writeln("<warning>This site does not have an SSL Certificate.</warning>"); | |||
| $output->writeln("<warning>This site does not have an SSL Certificate or isn't publicly accessible.</warning>"); | |||
There was a problem hiding this comment.
I think this message Site isn't publicly accessible should be added inside catch because this condition just checks if site url contains https or not.
| @@ -47,14 +47,16 @@ protected function execute(InputInterface $input, OutputInterface $output) { | |||
| } | |||
| // @TODO: This needs to be fixed. The 'https' is not present in the URL. | |||
| if (strpos($url, 'https') !== 0) { | |||
| $output->writeln("<warning>This site does not have an SSL Certificate.</warning>"); | |||
| $output->writeln("<warning>This site does not have an SSL Certificate or isn't publicly accessible.</warning>"); | |||
| return 0; | |||
| } | |||
| try { | |||
| $cert = $this->getCertByHostname($url); | |||
| } | |||
| catch (\Exception $e) { | |||
| $output->writeln("<warning>Something went wrong getting the SSL cert of $url</warning>"); | |||
There was a problem hiding this comment.
Suggested change
| $output->writeln("<warning>Something went wrong getting the SSL cert of $url</warning>"); | |
| $output->writeln("<warning>Something went wrong getting the SSL cert of $url or it's not publicly accessible.</warning>"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.