Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki - Fix dependencies list on wiki #10109

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Jul 5, 2024

When merged this pull request will:

Question:
How do I go about fixing https://ace3.acemod.org/wiki/development/dependencies#medical-menu? I don't understand to what it's referring to (ace_medical_gui includes both interactions and the medical menu).

Future TODOs:

  • Make title clickable so that they update the url to their position. I couldn't wrap my head around where that needs to be added.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the ignore-changelog Release Notes: Excluded label Jul 5, 2024
@johnb432 johnb432 added this to the Ongoing milestone Jul 5, 2024
Comment on lines +3 to +4
gem 'tzinfo-data'
gem 'webrick'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built it locally with jekyll 4.3.3, which wanted me to add these two.

docs/wiki/feature/maverick.md Outdated Show resolved Hide resolved
docs/wiki/feature/maverick.md Outdated Show resolved Hide resolved
Co-authored-by: Jouni Järvinen <[email protected]>
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM. Don't know enough about gem to comment on that.

@LinkIsGrim
Copy link
Contributor

component: medical_menu
change to medical_gui?

@johnb432
Copy link
Contributor Author

johnb432 commented Jul 8, 2024

component: medical_menu

change to medical_gui?

What would the description look like? Because it adds both interactions and the medical menu.

The part this is entirely optional is what is bothering with the current description.

@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Jul 8, 2024

IMO drop that whole part of docs. It never had much and medical_menu isn't a separate component post-rewrite.

Changing component to medical_gui would fix dependency listing. medical_menu component doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changelog Release Notes: Excluded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants