-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explosives - Improve AT, SLAM and Claymore Mines #10105
base: master
Are you sure you want to change the base?
Conversation
@BrettMayson FYI, the duplicate class definition that I fixed with 581a62e was detected by the PR's pipeline and threw an error, but is not logged as an error by HEMTT v1.12.4. |
Noticed you're basing your PR from this PR #9728. Sorry if I threw a wrench in any of your work, there were some issues with using init event handlers until we get Also question, should your WIP claymore produce some of the 700 fragments spread in every direction, or just forward? |
Thanks for the heads-up. Don't worry about it, I just need your excellent changes as a base to test explosive improvements, merge conflicts are only a minor hurdle while this PR is WIP anyway 👍🏻 My goal for the Claymore is to reduce its damage against buildings (without tweaking overall damage too much) and ideally get it to generate a realistic frag pattern, which includes a bit of shrapnel to its rear, since it has a rear danger zone of <1m right now. |
Co-Authored-By: lambdatiger <[email protected]>
So that it triggers on lighter vehicles, including Wiesel Tankettes. https://en.wikipedia.org/wiki/M15_mine#Specifications
581a62e
to
fc85a04
Compare
When merged this pull request will:
Previously they would only trigger at >7t, keeping Wiesel Tankettes (~4t) completely safe. Now they will detonate under any vehicle heavier (>300kg) than the vanilla quad bike (280kg).
Previously it wouldn't destroy cars and barely damage trucks (while killing the crew only in side-attack mode). Now it can reliably destroy them in both bottom and side-attacks, while also dealing slightly more damage to armored targets.
Still needs to be tweaked and tested a bit in various conditions as to not end up reducing ranged damage.
Changes are based on and require #9728.