Added dynamic stack using array and template #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
redhawk2002
commented
Oct 6, 2021
redhawk2002
commented
- added README.md file containing Dynamic Stack content.
- added dynamic_stacks_using_array_and_template.cpp file.
- updated README.md file of Open-DSA.
…and_dynamicStack.cpp to Data Structures/Stacks/dynamic stack/dynamic_stacks_using_array_and_template.cpp
|
@abxhr can you review this? |
abxhr
requested changes
Oct 7, 2021
Comment on lines
1
to
6
| # Dynamic stack using array | ||
| The idea of a dynamic stack is to allocate additional memory so that the "stack full" scenario does not occur frequently. | ||
| By allocating new memory that is bigger than the existing stack memory and copying elements from the old stack to the new stack, a Growable array-based Stack may be created. | ||
| ## Templates | ||
| The basic concept is to give the data type as a parameter, eliminating the need to write the same code for multiple data types. A software firm, for example, may require sort() for several data type. We can build a single sort() function and give data type as a parameter instead of creating and maintaining several codes. | ||
| ## Operations |
There was a problem hiding this comment.
Leave a blank line after the ending of each section
Comment on lines
7
to
45
|
|
||
| - size(): | ||
|
|
||
| ``` | ||
| return nextIndex; | ||
| ``` | ||
|
|
||
| - checkEmpty(): | ||
| ``` | ||
| return nextIndex==0; | ||
| ``` | ||
| - push(x): | ||
| ``` | ||
| if(nextIndex==capacity){ | ||
| T *newdata=new T[capacity*2]; | ||
| for(int i=0;i<capacity;i++){ | ||
| newdata[i]=data[i]; | ||
| } | ||
| capacity*=2; | ||
| delete []data; | ||
| data=newdata; | ||
| } | ||
| data[nextIndex]=element; | ||
| nextIndex++; | ||
| ``` | ||
| - pop(): | ||
| ``` | ||
| if(checkEmpty()){ | ||
| cout<<"stack is empty"<<endl; | ||
| return 0; | ||
| } | ||
| nextIndex--; | ||
| return data[nextIndex]; | ||
|
|
||
| ``` | ||
| - top(): | ||
| ``` | ||
| return data[nextIndex-1]; | ||
|
|
There was a problem hiding this comment.
- For the titles (eg:
pop()), try to mention them through backticks, to format them better. Do this for all the function titles.
eg:
`pop()`
is rendered as pop()
- The code snippets are not indented well. Try to indent them from the left margin
- The code snippet for
top()is not closed.
Comment on lines
51
to
58
| ## Applications: | ||
|
|
||
| - expression evaluation. | ||
| - check parenthesis matching in an expression. | ||
| - Conversion from one form of expression to another. | ||
| - Memory Management. | ||
| - backtracking problems. | ||
|
|
There was a problem hiding this comment.
The first character of each sentence is not capitalised.
|
@abxhr I have resolved the errors mentioned. |
abxhr
approved these changes
Oct 7, 2021
|
LGTM ✅ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.