Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after get_lang_files.sh screen is shown, simutrans aborts immediately #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rofl0r
Copy link

@rofl0r rofl0r commented Sep 9, 2018

and thus one doesn't have time to read the message about get_lang_files.sh

i was only able to see it after i started simutrans with gdb

@rofl0r
Copy link
Author

rofl0r commented Sep 9, 2018

btw the get_lang.sh script is not compatible with busybox unzip :/

$ sh get_lang_files.sh 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 10738    0 10701  100    37   1607      5  0:00:07  0:00:06  0:00:01  2757
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 1084k  100 1084k    0     0   246k      0  0:00:04  0:00:04 --:--:--  246k
/bin/unzip: unrecognized option: t
BusyBox v1.27.2 (2018-03-18 01:33:51 UTC) multi-call binary.

Usage: unzip [-lnopq] FILE[.zip] [FILE]... [-x FILE...] [-d DIR]

Extract FILEs from ZIP archive

        -l      List contents (with -q for short form)
        -n      Never overwrite files (default: ask)
        -o      Overwrite
        -p      Print to stdout
        -q      Quiet
        -x FILE Exclude FILEs
        -d DIR  Extract into DIR
Error: file language_pack-Base+texts.zip seems to be defective


@rofl0r
Copy link
Author

rofl0r commented Sep 10, 2018

also pak128.german can't be loaded due to some error about double objects

@rofl0r
Copy link
Author

rofl0r commented Sep 10, 2018

btw the reason i use git and not release 120.3 is that he source .zip from sourceforge extracts into ".". that means if you go to /tmp and unzip the file, you'll have /tmp/Makefile etc, instead of
/tmp/simutrans-120.3-source/Makefile as it should be. this is not compatible with our automatic build system and would need special workarounds

i'd highly appreciate if future tarballs (yup, a tarball would be prefered over a .zip) extracted to a directory name equivalent to the tarball name, as is good practice in FOSS.
example: gzip-1.0.4.tar.bz2 extracts to gzip-1.0.4/

ceeac pushed a commit to ceeac/simutrans that referenced this pull request Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant