-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce "all" and "none" specifiers #146
base: main
Are you sure you want to change the base?
Conversation
Do we check somewhere that the strings are just |
@immqu Please also check that your commits are signed (see DCO fails). |
Signed-off-by: Immanuel Kunz <[email protected]> Signed-off-by: Kunz, Immanuel <[email protected]>
Signed-off-by: Immanuel Kunz <[email protected]> Signed-off-by: Kunz, Immanuel <[email protected]>
Signed-off-by: Kunz, Immanuel <[email protected]>
Currently, it is checked whether the |
Signed-off-by: Kunz, Immanuel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Kunz, Immanuel <[email protected]>
Signed-off-by: Kunz, Immanuel <[email protected]>
See also the corresponding PR for purl |
This PR introduces the possibility to specify all versions, or none using the notation
vers:all/*
andvers:none/*
. To allow this, it simply adds a version check in the contains method that returns true if all is specified, and false if none is specified.Addresses the spec improvement suggested in package-url/purl-spec#267