Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system should use available deps instead of externals when they are available #1325

Open
bzizou opened this issue Jul 3, 2024 · 0 comments

Comments

@bzizou
Copy link
Contributor

bzizou commented Jul 3, 2024

Is your feature request related to a problem? Please describe. For generic questions use Q&A section in the Discussions forum above.

Some package managers (Nix, Guix,...) are able to provide fixed dependencies, with pinned versions when needed and that should replace the use of some ext/ redistributed projects. If I'm not wrong, the cmake files of Spades are not picking the deps when they are available (for example zlib-ng, gtest,...) and are always using the ext directory. In some cases, this leads to build failures, for example when using the Musl libc. Thos build failure are avoided if the deps are provided by the package manager (because deps packages are already fixed for that libc). For more infrmations, you can check this PR discussion: NixOS/nixpkgs#320502

Describe the solution you'd like

When for example zilb-ng is available and with a suitable version number, then use it in place of the one that has been redistributed into the ext directory

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant