Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --cpus flag as an alias for --cpu to align with lima #1055

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SmartManoj
Copy link

@SmartManoj SmartManoj commented Jul 2, 2024

Adds support for the --cpus flag in the start command, functioning as an alias for the --cpu flag.

  • Introduces a new CLI flag --cpus in cmd/start.go, allowing users to specify the number of CPUs. This flag behaves identically to the existing --cpu flag.
  • Ensures that both --cpu and --cpus flags are parsed and handled equivalently, maintaining backward compatibility and user flexibility in specifying CPU resources.

Lima docs

For more details, open the Copilot Workspace session.

@abiosoft
Copy link
Owner

abiosoft commented Jul 3, 2024

Thanks for this. However, the implementation is not yet complete.

@SmartManoj
Copy link
Author

  • Ensures that both --cpu and --cpus flags are parsed and handled equivalently, maintaining backward compatibility and user flexibility in specifying CPU resources.

You meant this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants