Validate PackageName #377
Merged
Validate PackageName #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 79 79
=========================================
Hits 79 79 ☔ View full report in Codecov by Sentry. |
Uses regex to make sure that the package name starts with a capital letter and contains only letters and numbers. Closes #373
abelsiqueira
force-pushed
the
373-validate-package-name
branch
from
c46bb95
to
3e2e9d0
Compare
|
@jhidding, would you like to review this? |
|
Thanks for review! @allcontributors please add @jhidding for review |
|
@allcontributors please add @jhidding for review |
|
I've put up a pull request to add @thanks! 🎉 I've put up a pull request to add @jhidding! 🎉 |
|
We had trouble processing your request. Please try again later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses regex to make sure that the package name starts with a capital letter and contains only letters and numbers.
Closes #373
Related issues
Checklist