Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review doc #35

Merged
merged 9 commits into from
Oct 2, 2023
Merged

Review doc #35

merged 9 commits into from
Oct 2, 2023

Conversation

tmigot
Copy link
Contributor

@tmigot tmigot commented Oct 1, 2023

Hi @abelsiqueira
Here are some minor comments on the doc.
Overall, it looks good to me. I am sure more comments will come as we use it.
Thank you for all the work done in this template !

docs/src/developer.md Outdated Show resolved Hide resolved
docs/src/developer.md Outdated Show resolved Hide resolved
docs/src/developer.md Outdated Show resolved Hide resolved
Copy link
Owner

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tangi, thanks for the PR. I've moved your changes to the internal template instead to check that they will propagate with the workflow.

@abelsiqueira abelsiqueira merged commit 1292e49 into abelsiqueira:main Oct 2, 2023
1 check passed
@tmigot tmigot deleted the rev-doc branch October 2, 2023 09:59
@abelsiqueira
Copy link
Owner

@all-contributors please add @tmigot for code and docs

Copy link
Contributor

@abelsiqueira

I've put up a pull request to add @tmigot! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants