fix: 🐛 Add continue-on-error to allow nightly to fail

On Test.yml, add missing continue-on-error that interacts with allow_failure in the matrix and decides whether the ubilds can fail or not. This allows nightly builds to fail. ✅ Closes: #51
abelsiqueira · May 17, 2024 · daff692 · daff692
1 parent 20f952d
commit daff692
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/.github/workflows/Test.yml b/.github/workflows/Test.yml
@@ -29,6 +29,7 @@ jobs:
   test:
     name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
     runs-on: ${{ matrix.os }}
+    continue-on-error: ${{ matrix.allow_failure }}
     strategy:
       fail-fast: false
       matrix:

diff --git a/template/.github/workflows/Test.yml.jinja b/template/.github/workflows/Test.yml.jinja
@@ -28,6 +28,7 @@ jobs:
   test:
     {% raw %}name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
     runs-on: ${{ matrix.os }}{% endraw %}
+    continue-on-error: ${{ matrix.allow_failure }}
     strategy:
       fail-fast: false
       matrix: