Skip to content

Commit

Permalink
Make TestOnPRs part of minimal template
Browse files Browse the repository at this point in the history
The intrusive part of TestOnPRs is the ReusableTest, which is already
added in the minimal. So we might as well benefit from it and have the
improved PR testing.
This removes the question and fix the files accordingly.

Closes #312

Breaking change: Question SimplifiedPRTest is removed. If you chose
recommended or explicitly answered it as true, nothing changes.
If you chose minimum or explicitly answered it as false, you will have a
new file .github/workflows/TestOnPRs.yml and your Test.yml will change.
Pull Requests will run on a smaller matrix now. See the docs for more
information.
  • Loading branch information
abelsiqueira committed Jul 8, 2024
1 parent e96f3be commit d05e649
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 15 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@ and this project adheres to [Semantic Versioning].

### Changed

- GitHub PR template is now part of the minimal options (#308)
- (breaking change) GitHub PR template is now part of the minimal options (#308)
- (breaking change) TestOnPRs.yml is now part of the minimal options (#312)

### Removed

- (breaking change) Question SimplifiedPRTest was removed and the behaviour now is as if it were selected as true (#312)

## [0.7.2] - 2024-07-07

Expand Down
6 changes: 0 additions & 6 deletions copier.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,6 @@ AddPrecommit:
help: Pre-commit (Whether to add pre-commit.org. It runs before every commit fixing your formatting and preventing bad practices)

# CI
SimplifiedPRTest:
when: "{{ AnswerStrategy == 'ask' }}"
type: bool
help: Simplified PR Test (Do you want to limit the Pull Request test to a single configuration (ubuntu + latest stable Julia)? This will make the PR tests run faster, but might miss OS-specific or LTS specific errors)
default: "{{ AnswerStrategy != 'minimum' }}"

AddMacToCI:
when: "{{ AnswerStrategy == 'ask' }}"
type: bool
Expand Down
8 changes: 0 additions & 8 deletions template/.github/workflows/Test.yml.jinja
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,6 @@ on:
branches:
- main
tags: ["*"]
{% if not SimplifiedPRTest %}pull_request:
branches:
- main
paths:
- "src/**"
- "test/**"
- "*.toml"
types: [opened, synchronize, reopened]{% endif %}
workflow_dispatch:

jobs:
Expand Down

0 comments on commit d05e649

Please sign in to comment.