Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup deprecated and removed NumPy APIs in C extension #34

Merged
merged 8 commits into from
Jul 16, 2024

Conversation

chazeon
Copy link
Contributor

@chazeon chazeon commented Jul 16, 2024

NumPy recently was upgraded to 2.0, and a lot of old deprecated APIs were removed. This PR addresses these changes.

@chazeon chazeon marked this pull request as draft July 16, 2024 14:34
@chazeon chazeon marked this pull request as ready for review July 16, 2024 15:59
@chazeon
Copy link
Contributor Author

chazeon commented Jul 16, 2024

I have run unit tests locally. The test_q_points_data might not pass.
I directly compared the results, and it doesn't seem to be very different, so the criteria of rms = 0.05 might be too strict.

Si_test

@chazeon chazeon changed the title Cleanup depreciated and removed NumPy APIs in C extension Cleanup deprecated and removed NumPy APIs in C extension Jul 16, 2024
@abelcarreras
Copy link
Owner

Thank you very much for your contribution @chazeon. This week I am a little busy but I will try to find some time to revise it. You are probably right about the RMS criteria.

@chazeon
Copy link
Contributor Author

chazeon commented Jul 16, 2024

Thank you! The test can pass on CI, which is quite strange.

@abelcarreras abelcarreras merged commit ac78eda into abelcarreras:master Jul 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants