Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove Superfest Base incentives #2175

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

NandyBa
Copy link
Contributor

@NandyBa NandyBa commented Sep 9, 2024

General Changes

  • Removed the Superfest Base incentive indicator from the UI.
  • Refactored the logic related to Superfest's next chain incentive, removing its indicator in the codebase.
  • Updated ESLint's no-unused-vars rule to include an ignore pattern, which is necessary to preserve the _showSuperFestTooltip_ function signature.

Former Intention

  • The initial goal was to remove the Superfest Base incentive indicator.
  • Additionally, we aimed to display a sub-banner for two weeks, notifying eligible users about unclaimed rewards.

Developer Notes

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

Copy link

height bot commented Sep 9, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@NandyBa NandyBa changed the title feat: remove Superfest incentive feat: remove Superfest Base incentive Sep 9, 2024
@NandyBa NandyBa changed the title feat: remove Superfest Base incentive feat: remove Superfest Base incentives Sep 9, 2024
src/utils/utils.ts Outdated Show resolved Hide resolved
src/components/incentives/IncentivesCard.tsx Outdated Show resolved Hide resolved
previous  USDC incentive fix push by accident
and remove @typescript-eslint/no-unused-vars changes
Copy link

github-actions bot commented Sep 10, 2024

❌ CI run has failed!
Please see logs at https://github.com/aave/interface/actions/runs/10793774614'

Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 544.43 KB (🟢 -61 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/bridge 35.88 KB (🟢 -25 B) 580.31 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@grothem grothem merged commit 6af79c9 into aave:main Sep 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants