Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: further cleanup #201

Merged
merged 11 commits into from
Oct 25, 2022

Conversation

sakulstra
Copy link
Collaborator

@sakulstra sakulstra commented Oct 24, 2022

this pr assumed default branch to be changed to main and Pending-aips being pushed to main after merge

This pr resolves the points

  • proposal naming: the readme just sais "uppercase name" and the ci enforces this in pr validation. No more hash. In theory AIP-num prs could be renamed, but that's bit cumbersome work. Might do it in new pr.
  • removing status: it's removed from templates & validation. We don't remove it from existing aip payloads as this would alter the hash.
  • branching: @kartojal once this is merged default branch has to be changed and you need to push Pending-AIPs to main

What this pr does not cover is pr ipfs previews: was looking a bit into this but perhaps someone involved in aave interface ci can have a look as I didn't quite understand how pull_request vs pull_request_target stuff works.

scripts/aip-uploader.js Show resolved Hide resolved
scripts/aip-uploader.js Show resolved Hide resolved
package.json Show resolved Hide resolved
refactor: remove all ipfs

refactor: revert changes to all-ipfs
@miguelmtzinf miguelmtzinf merged commit b22455d into aave:Pending-AIPs Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants