Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement Reverse Index (fixes nano scrolling) #80

Merged
merged 2 commits into from
Aug 1, 2020
Merged

implement Reverse Index (fixes nano scrolling) #80

merged 2 commits into from
Aug 1, 2020

Conversation

aaronjanse
Copy link
Owner

Implements Reverse Index, which is pretty much a backward newline. Fixes scrolling in nano

https://docs.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences

@aaronjanse aaronjanse requested a review from PotatoParser July 31, 2020 23:42
PotatoParser
PotatoParser requested changes Aug 1, 2020
View reviewed changes
Copy link
Collaborator

@PotatoParser PotatoParser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Is this intended to fix a part of @ #79 ?

vterm/stdout.go Outdated Show resolved Hide resolved
@aaronjanse
Copy link
Owner Author

Awesome! Is this intended to fix a part of @ #79 ?

Yep! I just pushed another commit to fix downward scrolling, too.

Gist of what this PR does:

  1. Previously, ESC 7 and ESC 8 (cursor save/restore) were not recognized. In addition to not saving/restoring the cursor, this also caused a newline character to be ignored (because it was slurped while trying to figure out what ESC 7/8 mean)
  2. Previously, Reverse Index (inverse newline) was recognized by the parser but not handled by vterm

@aaronjanse aaronjanse requested a review from PotatoParser August 1, 2020 01:00
PotatoParser
PotatoParser approved these changes Aug 1, 2020
View reviewed changes
Copy link
Collaborator

@PotatoParser PotatoParser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed nano #79

@aaronjanse aaronjanse merged commit 447aa2e into master Aug 1, 2020
@aaronjanse aaronjanse deleted the fix-nano-scroll branch March 8, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PotatoParser PotatoParser PotatoParser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronjanse @PotatoParser