-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Classwise Shapley #616
Refactor Classwise Shapley #616
Conversation
…s score computation
… new object manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Kristof Schröder <[email protected]>
@schroedk I resolved as many issues as possible but there is still one test that fails for some unknown reason and I am giving up on it. The test in question relies on non-default behaviour, i.e., it does not normalize the values after the valuation. The original paper's implementation normalizes the values and for that case the test passes. |
@AnesBenmerzoug the test is also failing on #558. Let's go for merging this branch and then iterate on #558. |
@schroedk the test I was talking about is specific to classwise shapley. I have no idea about that other test that is failing. I think this PR can now be merged. |
Description
This PR refactors the Classwise Shapley valuation to be more aligned with the new Valuation classes.
Changes
with_idx
andwith_subset
methods toSample
class.Checklist
Updated Documentation (if necessary)If notebooks were added/changed, added boilerplate cells are tagged with"tags": ["hide"]
or"tags": ["hide-input"]