feature: cache services dns path, fix issue 91 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is anybody here to maintain? |
|
Yo i'm going to review this soon. Regards |
|
Hi ! I am currently integrating your fix but I see that the tests are not valid. Regards |
|
Hi, Thanks for response! Do you want me to fix all the tests? I can make it, if the idea of changes is ok |
|
Dont sorry I am fixing it :) Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Sorry for unfinished PR.
I just want somebody to review it first 😄
This is the try of solving this issue #91
Common idea is to cache dns names as treen, it allows to navigate faster and to resolve names correctly