-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Offset-Eq Constraints #415
Conversation
Before merging: Make sure the allocated sizes of Az, Bz, Cz in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, just one q
jolt-core/src/r1cs/key.rs
Outdated
let row_constr_eq_non_uni = | ||
EqPolynomial::new(r_row_constr.to_vec()).evaluate(&non_uni_constraint_index); | ||
|
||
debug_assert_eq!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be a normal assert_eq!
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't hurt perf much, switching.
Expands the non-uniform offset eq constraints to support multiple constraints.