App size #146

neithanmo · 2023-02-09T20:49:39Z

This PR aims to reduce the app size, applying some techniques that were used with another Rust app(AVAX):

optimize for size using "z" flag.
Remove Debug symbols.
Avoid panicking replacing as much indexing as possible, with get(), get_mut variants.
Update zxlib to the latest version which includes checks for character sizes in nanos, this fixes Ledger Nano S screen showing incorrect address (40 instead of 41 characters) #142

use try call to avoid panic machinery to be added by the compiler optimize for binary size and remove debug symbols

ghost

Good job! To be fair the biggest improvement I saw on avalanche was removing rlib from the crate types, but it seems like it's not used here, so 🤷...

Anyways, good cleanup!

app/rust/src/parser/c32.rs

app/rust/src/parser/message.rs

app/rust/src/parser/spending_condition.rs

app/rust/src/parser/structured_msg.rs

app/rust/src/parser/transaction_payload.rs

app/rust/src/parser/utils.rs

ghost

Not sure if those are better with iter_mut or were forgotten

app/rust/src/parser/c32.rs

app/rust/src/parser/message.rs

app/rust/src/parser/structured_msg.rs

ftheirs · 2023-02-22T14:46:02Z

Closing this #145

* avoid indexing to reduce binary size use try call to avoid panic machinery to be added by the compiler optimize for binary size and remove debug symbols * update tests * bump app version and update snapshots * Derive Debug only under test * Remove panic-halt to reduce app size * Reduce calls to procedures that can cause panics * Rename LedgerPanic to ApduPanic * fix format * use unreachable_unchecked * some improvements in size * fix return value * Update zxlib * use copy_from_slice and better error report

neithanmo added 7 commits February 7, 2023 16:26

avoid indexing to reduce binary size

c74023b

use try call to avoid panic machinery to be added by the compiler optimize for binary size and remove debug symbols

update tests

a488252

bump app version and update snapshots

a27817a

Derive Debug only under test

afbc13c

Remove panic-halt to reduce app size

03cef9f

Reduce calls to procedures that can cause panics

d2dfb07

Rename LedgerPanic to ApduPanic

4c70553

neithanmo requested a review from ftheirs February 9, 2023 20:49

fix format

e7d8fcd

ghost suggested changes Feb 10, 2023

View reviewed changes

neithanmo added 4 commits February 13, 2023 18:21

use unreachable_unchecked

c293143

some improvements in size

649b51b

fix return value

e0aef79

Update zxlib

9e7b17f

neithanmo requested a review from a user February 15, 2023 15:38

ftheirs approved these changes Feb 16, 2023

View reviewed changes

ghost suggested changes Feb 20, 2023

View reviewed changes

app/rust/src/parser/c32.rs Outdated Show resolved Hide resolved

app/rust/src/parser/message.rs Outdated Show resolved Hide resolved

app/rust/src/parser/structured_msg.rs Outdated Show resolved Hide resolved

use copy_from_slice and better error report

b44ef37

ghost approved these changes Feb 21, 2023

View reviewed changes

neithanmo merged commit 5f40d62 into main Feb 21, 2023

neithanmo mentioned this pull request Feb 23, 2023

Ledger Nano S screen showing incorrect address (40 instead of 41 characters) #142

Closed

carlosala deleted the app_size branch June 2, 2023 06:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

App size #146

App size #146

neithanmo commented Feb 9, 2023 •

edited

Loading

ghost left a comment

ghost left a comment

ftheirs commented Feb 22, 2023

App size #146

App size #146

Conversation

neithanmo commented Feb 9, 2023 • edited Loading

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ftheirs commented Feb 22, 2023

neithanmo commented Feb 9, 2023 •

edited

Loading