Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Metadata is included by default, Add: exclude_data arg to exclude meta_data #10

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

pk-zipstack
Copy link
Contributor

What

  • Made meta_data available by default and introduced a --exclude_metadata flag to allow users to opt out of metadata inclusion in API requests.

Why

  • Previously, metadata inclusion was controlled by an --include_metadata flag, which defaulted to False. The new flag ensures that metadata is included by default, aligning with expected behaviour and simplifying usage.

How

  • Replaced the --include_metadata flag with the --exclude_metadata flag.
  • Updated logic to default metadata inclusion to True unless explicitly overridden by the new flag.
  • Adjusted documentation and help text to reflect the change.

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

  • No, but the users who are using --include_metadata as a argument may face issues.

@pk-zipstack pk-zipstack requested review from ritwik-g and a team November 19, 2024 06:14
@pk-zipstack pk-zipstack self-assigned this Nov 19, 2024
@pk-zipstack pk-zipstack requested review from kirtimanmishrazipstack and removed request for a team November 19, 2024 06:14
@pk-zipstack pk-zipstack merged commit 582b0d1 into main Nov 19, 2024
2 checks passed
@pk-zipstack pk-zipstack deleted the exclude-metadata-arg branch November 19, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants