[Draft] Force move rearming planes #4474
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giving a plane on an airpad a move order will make all the planes on that airpad get off of it. Strangely everyone but the plane you gave the move order to will return to the pad. Perhaps it has to do with a double cancelairpadreservation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Giving a plane on an airpad a move order will make all the planes on that airpad get off of it and it will be excluded to fix #3971 an issue I see with this is that people with the exclude airpad command hidden (as is the default) will have no idea how to unmark an excluded airpad. At the same time, the feature is kind of useless with airpad exclusion as planes will immediately try going back to it.
Also, changes in this mean that finally excluding an airpad with planes on it will make those planes leave.
One of the things that has to be done is turning this into a hidden command so it can be bindable, and also fixing the issue where strangely every plane on an airpad but the plane you gave the move order to will return to the pad, if you exclude an airpad with a plane currently on it but don't give it a move order it exhibits the same behaviour. I've tried everything from removing CMD_REARM from planes on the airpad to not setting an airpad as unreserved (Which will cause problems if it is not revert....) I've left them in for the time being so you can see what I've tried. Any help would be appreciated. Perhaps it has to do with the fact that the plane that receives the move order gets a double cancelairpadreservation?