Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host/Join CCMDs for easier netgame access #1927

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

RicardoLuis0
Copy link
Collaborator

host NUMPLAYERS [MAP=X LOADSAVE=X PORT=X SKILL=X TICDUP=X EXTRATIC PACKET_SERVER DEATHMATCH ALTDEATH]
join ADDR [LOADSAVE=X PORT=X]

(the optional arguments may be passed in any order)

@RicardoLuis0 RicardoLuis0 force-pushed the multiplayer-menu-experiment branch 2 times, most recently from ee883a9 to 17e5dca Compare January 11, 2023 04:03
@RicardoLuis0 RicardoLuis0 marked this pull request as ready for review January 11, 2023 16:31
@TehRealSalt
Copy link
Contributor

TehRealSalt commented Jan 16, 2023

I wasn't able to get deathmatch to work, would always load as Coop. Was using this as the command: host 2 port=5031 map=vs1 deathmatch

But other than that, this works very well! Massive quality of life improvement over what's already there.

@RicardoLuis0
Copy link
Collaborator Author

Ah, i forgot to add the == 0 on the CCMD's zero-argument parameters 🤦‍♂️

@TehRealSalt
Copy link
Contributor

Deathmatch flag has been fixed 😄

But the latest commit appears to add a new bug; post-processing shaders gets double-loaded. Noticed it with my IWAD's CRT post-process shader.

Minimum reproduction test pk3:
post-process-test.zip

It's a basic post-process shader that darkens the screen by 50%. Hosting with this added will make it 25%.

@RicardoLuis0
Copy link
Collaborator Author

I don't know much about the shader/rendering part of gzdoom's code, i'll ask if someone else can take a look at it

@RicardoLuis0 RicardoLuis0 force-pushed the multiplayer-menu-experiment branch from be52394 to 405bfd3 Compare January 21, 2023 17:27
@MajorCooke
Copy link
Contributor

Of note this will have a minor merge conflict if #1964 gets in before this one, just a heads up.

MajorCooke added a commit to ZDoom/qzdoom that referenced this pull request Jan 21, 2023
@MajorCooke MajorCooke mentioned this pull request Jan 21, 2023
17 tasks
@CandiceJoy
Copy link
Member

When I host a game via the CCMD command with a number greater than 1, the game simply freezes. It's probably waiting for a connection, but without a message or SOMETHING....that's not good IMHO, especially since you literally can't do anything until it stops (ie someone connects, purportedly) :P #1927

@RicardoLuis0
Copy link
Collaborator Author

When I host a game via the CCMD command with a number greater than 1, the game simply freezes. It's probably waiting for a connection, but without a message or SOMETHING....that's not good IMHO, especially since you literally can't do anything until it stops (ie someone connects, purportedly) :P #1927

are you on a non-windows platform? that's the exact thing that I_NetRestartShowConsole fixes on windows, but i don't have a dev machine for linux or macos to be able to implement it on those platforms

@CandiceJoy
Copy link
Member

When I host a game via the CCMD command with a number greater than 1, the game simply freezes. It's probably waiting for a connection, but without a message or SOMETHING....that's not good IMHO, especially since you literally can't do anything until it stops (ie someone connects, purportedly) :P #1927

are you on a non-windows platform? that's the exact thing that I_NetRestartShowConsole fixes on windows, but i don't have a dev machine for linux or macos to be able to implement it on those platforms

Yeah, I'm on MacOS.

@RicardoLuis0
Copy link
Collaborator Author

Yeah, I'm on MacOS.

it should show a progress bar at least if you run it from a window instead of fullscreen (at least it did on windows before I_NetRestartShowConsole was implemented)

@madame-rachelle
Copy link
Collaborator

This one has conflicts, probably due to the move to the new ZWidget system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants