Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: escape special characters in string template literals #603

Merged
merged 2 commits into from
May 14, 2024
Merged

fix: escape special characters in string template literals #603

merged 2 commits into from
May 14, 2024

Conversation

ahochsteger
Copy link
Contributor

Please:

  • Make your pull request atomic, fixing one issue at a time unless there are many relevant issues that cannot be decoupled.
  • Provide a test case & update the documentation in the Readme.md

Fixes #602

@domoritz
Copy link
Collaborator

domoritz commented May 13, 2024 •
edited
Loading

The tests are failing.

@ahochsteger
Copy link
Contributor Author

@domoritz thanks for spotting, the quoting issue ist now fixed.

@domoritz domoritz merged commit 54a651c into YousefED:master May 14, 2024
1 check passed
@domoritz domoritz mentioned this pull request May 14, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RegExp special characters are not escaped for string template literals
2 participants
@ahochsteger @domoritz