Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove suppressImplicitAnyIndexErrors from tsconfig #593

Merged

Conversation

raineorshine
Copy link
Contributor

@raineorshine raineorshine commented Mar 14, 2024

Please:

  • Make your pull request atomic, fixing one issue at a time unless there are many relevant issues that cannot be decoupled.
  • Provide a test case & update the documentation in the Readme.md

This PR is a continuation of the Typescript v5 upgrade (#564) that factors out the implicit use of index signatures, allowing suppressImplicitAnyIndexErrors and ignoreDeprecations to be removed from the tsconfig.

Due to the extensive use of indexing into interfaces (namely Definition), I have created a DefinitionIndex type that is a looser version of Definition allowing indexing. In other cases I needed to cast a type as a Record or cast a key as keyof Definition in order to allow the desired indexing.

Let me know if you know of a more elegant approach, or have any additional feedback.

@domoritz domoritz merged commit 264ab45 into YousefED:master Mar 15, 2024
1 check passed
@domoritz
Copy link
Collaborator

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants