fix: return overrides schema in getSchemaForSymbol #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Thanks for the pull requests. Can you update this pull request so we can merge it? |
lundibundi
force-pushed
the
return-overrides-in-get-schema
branch
from
d9c9bcb
to
f1395b6
Compare
lundibundi
force-pushed
the
return-overrides-in-get-schema
branch
from
f1395b6
to
5b7b28a
Compare
|
@domoritz done, thanks for quick merge. When can I expect to have this released? |
|
v0.63.0 is out with this fix included. |
|
@domoritz thank you 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please:
Readme.mdDepends on #589.
The
getSchemaForSymbolmethod doesn't return schemas overridden withsetSchemaOverrideand instead falls back to generating the type for that schema. This PR changes the behavior to always prioritizesetSchemaOverride.